-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update_count is reset once updated, cause cache key conflict #9811
fix: update_count is reset once updated, cause cache key conflict #9811
Conversation
No test cases? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The title of PR needs to be able to see what problem is fixed
- Did not understand the relevant modification of the test case
The update_count is volatile, instead, we need to use monotonically increasing etcd modified revision. As a matter of fact, this bug cannot be triggered in the master branch, so that's why there is no dedicated test case. |
// As a matter of fact, this bug cannot be triggered in the master branch, so that's why there is no dedicated test case. So we don't need this PR? |
Yes, and no. I think it's necessary, As I said before, the original code should not use a volatile counter instead of the etcd revision, which is definitely a bad practice. |
The master branch does not need this fix, and is not sufficiently tested. |
@moonming Any more comments? |
fixed #9822 |
Description
update_count is reset once updated, which will cause lru cache key conflict, in turn reusing the old route conf.
Checklist