Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(limit_conn): do not use the http variable in stream mode #9816

Merged
merged 2 commits into from
Jul 12, 2023
Merged

fix(limit_conn): do not use the http variable in stream mode #9816

merged 2 commits into from
Jul 12, 2023

Conversation

Sn0rt
Copy link
Contributor

@Sn0rt Sn0rt commented Jul 11, 2023

Description

Fixes #9661

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@wxbty @Sn0rt
fix: only enable upstream_response_time for http
18a645d 
Signed-off-by: Sn0rt <wangguohao.2009@gmail.com>
monkeyDluffy6017
monkeyDluffy6017 requested changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@monkeyDluffy6017 monkeyDluffy6017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change the title of test cases

@monkeyDluffy6017 monkeyDluffy6017 added the wait for update wait for the author's response in this issue/PR label Jul 11, 2023
@Sn0rt
fix: rename the test case
6c92d5e 
Signed-off-by: Sn0rt <wangguohao.2009@gmail.com>
@monkeyDluffy6017 monkeyDluffy6017 added approved and removed wait for update wait for the author's response in this issue/PR labels Jul 11, 2023
@monkeyDluffy6017 monkeyDluffy6017 changed the title fix: only enable upstream_response_time for http fix(limit_conn): do not use the http variable in stream mode Jul 11, 2023
@monkeyDluffy6017 monkeyDluffy6017 merged commit 5b118e7 into apache:master Jul 12, 2023
@monkeyDluffy6017 monkeyDluffy6017 mentioned this pull request Jul 12, 2023
Closed
@Sn0rt Sn0rt deleted the bugfix_limit_conn branch November 9, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soulbird soulbird soulbird approved these changes

@monkeyDluffy6017 monkeyDluffy6017 monkeyDluffy6017 approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: limit-conn report error attribute does not exist
4 participants
@Sn0rt @monkeyDluffy6017 @soulbird @wxbty