Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change(ua-restriction): allowlist and denylist can't be enabled at the same time #9841

Merged
merged 7 commits into from
Jul 24, 2023
Merged

change(ua-restriction): allowlist and denylist can't be enabled at the same time #9841

merged 7 commits into from
Jul 24, 2023

Conversation

jiangfucheng
Copy link
Member

@jiangfucheng jiangfucheng commented Jul 15, 2023 •
edited
Loading

Description

Fixes #7467

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@monkeyDluffy6017 monkeyDluffy6017 changed the title fix: allowlist and denylist can't be enabled at the same time change(ua-restriction): allowlist and denylist can't be enabled at the same time Jul 17, 2023
@monkeyDluffy6017 monkeyDluffy6017 added the wait for update wait for the author's response in this issue/PR label Jul 17, 2023
@Sn0rt
Copy link
Contributor

Sn0rt commented Jul 18, 2023

@jiangfucheng thx your PR, pls take a look at the comments from monkeyDluffy6017

monkeyDluffy6017
monkeyDluffy6017 reviewed Jul 18, 2023
View reviewed changes
t/plugin/ua-restriction.t
@@ -340,136 +340,7 @@ User-Agent:foo/bar
hello world



=== TEST 18: bypass_missing test, using default, reset conf(part1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bypass_missing should work when allowlist or denylist exists and no user agent, the test case is needed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@monkeyDluffy6017 monkeyDluffy6017 added approved and removed wait for update wait for the author's response in this issue/PR labels Jul 19, 2023
@monkeyDluffy6017 monkeyDluffy6017 merged commit e6adec5 into apache:master Jul 24, 2023
40 checks passed
@jiangfucheng jiangfucheng deleted the ua-restriction branch July 24, 2023 05:49
rubikplanet pushed a commit to rubikplanet/apisix that referenced this pull request Aug 8, 2023
@jiangfucheng @rubikplanet
change(ua-restriction): allowlist and denylist can't be enabled at th…
1ce96d2 
…e same time (apache#9841)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monkeyDluffy6017 monkeyDluffy6017 monkeyDluffy6017 approved these changes

@leslie-tsang leslie-tsang leslie-tsang approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat:As a user, I don't think allowlist and denylist of ua-restriction can be enabled at the same time
4 participants
@jiangfucheng @Sn0rt @monkeyDluffy6017 @leslie-tsang