Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(limit-count): X-RateLimit-Reset shouldn't be set to 0 after request be rejected #9978

Merged
merged 2 commits into from
Aug 8, 2023
Merged

fix(limit-count): X-RateLimit-Reset shouldn't be set to 0 after request be rejected #9978

merged 2 commits into from
Aug 8, 2023

Conversation

jiangfucheng
Copy link
Member

…rejected

Description

Fixes #9964

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@jiangfucheng jiangfucheng changed the title fix: X-RateLimit-Reset shouldn't be set to 0 after request be rejected fix(limit-count): X-RateLimit-Reset shouldn't be set to 0 after request be rejected Aug 6, 2023
@moonming
Copy link
Member

moonming commented Aug 7, 2023

Not directly related to this PR, but somewhat related.
Where is the incoming function implemented in https://github.com/apache/apisix/blob/master/apisix/plugins/limit-count/limit-count-local.lua#L67? The standard function does not have the cost parameter.
@shreemaan-abhishek do you know this?

@monkeyDluffy6017 monkeyDluffy6017 merged commit 8f289ba into apache:master Aug 8, 2023
32 checks passed
rubikplanet pushed a commit to rubikplanet/apisix that referenced this pull request Aug 8, 2023
@jiangfucheng @rubikplanet
fix(limit-count): X-RateLimit-Reset shouldn't be set to 0 after reque…
9407f6e 
…st be rejected (apache#9978)
@jiangfucheng jiangfucheng deleted the fix_limit_count branch August 12, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monkeyDluffy6017 monkeyDluffy6017 monkeyDluffy6017 approved these changes

@leslie-tsang leslie-tsang leslie-tsang approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: limit count X-RateLimit-Reset is 0
4 participants
@jiangfucheng @moonming @monkeyDluffy6017 @leslie-tsang