Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make it support rewrite request body in external plugins #9990

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

rubikplanet
Copy link
Contributor

Description

Resubmit for #9864

Please update ext-plugin-proto first. api7/ext-plugin-proto#35

To make it be able to rewrite the request body in external plugins.

Add test according to https://github.com/jiangfucheng 's suggest.

Please help to correct it if something wrong, because i don't know how the test is working.

Fixes # (issue)

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@moonming
Copy link
Member

@monkeyDluffy6017 please take a look

@Revolyssup
Copy link
Contributor

This PR depends on api7/ext-plugin-proto#35

@monkeyDluffy6017 monkeyDluffy6017 added the wait for update wait for the author's response in this issue/PR label Aug 14, 2023
@monkeyDluffy6017
Copy link
Contributor

@jiangfucheng Could you help to review this?

@jiangfucheng jiangfucheng self-assigned this Aug 14, 2023
@jiangfucheng
Copy link
Member

jiangfucheng commented Aug 14, 2023

@monkeyDluffy6017 api7/ext-plugin-proto#35 This PR need to be merged first and we need to release a new version for ext-plugin-proto

@jiangfucheng
Copy link
Member

@monkeyDluffy6017 @Sn0rt Hi, could you help review api7/ext-plugin-proto#35? I will take over the current PR after api7/ext-plugin-proto#35 has been merged

@monkeyDluffy6017
Copy link
Contributor

@jiangfucheng the api7/ext-plugin-proto#35 is merged, please go on

@Revolyssup
Copy link
Contributor

@jiangfucheng Will you take this forward?

@jiangfucheng
Copy link
Member

jiangfucheng commented Sep 18, 2023

@jiangfucheng Will you take this forward?

ext-plugin-proto need to release a new version, and then we can use it in APISIX. I'm not a member of api7 org, so I need to wait for the maintainer of api7 to release the new version.

@Revolyssup Revolyssup removed the wait for update wait for the author's response in this issue/PR label Sep 18, 2023
@Revolyssup Revolyssup self-assigned this Sep 18, 2023
@Revolyssup
Copy link
Contributor

@jiangfucheng release has been made

@jiangfucheng
Copy link
Member

@monkeyDluffy6017 Hi, please take a look, thanks.

@jiangfucheng
Copy link
Member

I will try to support this feature in apisix-go-plugin-runner after this PR merged.

@monkeyDluffy6017 monkeyDluffy6017 merged commit 88da2ec into apache:master Sep 22, 2023
31 checks passed
@zxyao145
Copy link

Hi, which version is accessible? Is 3.2.x okay?

@monkeyDluffy6017
Copy link
Contributor

@zxyao145 This feature is integrated into v3.6.0, you can check the changelog: https://github.com/apache/apisix/blob/release/3.6/CHANGELOG.md#360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants