[ARIES-1992] Fix loss of PU override properties #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Memorize override PU props even if the required DataSource is not yet available. Always merge the memorized props into the static PU props before publishing an EntityManagerFactory. We have hold on to the override props although we might not yet be able to create an EntityManagerFactory, since we will not be notified about the updated props again. Resolves: ARIES-1992
sunshinebeauty93
changed the title
|
How can we continue with this? |
vassilz
reviewed
Apr 22, 2021
| @@ -83,6 +83,7 @@ | |||
|
|
|||
| private boolean complete; | |||
|
|
|||
| private Map<String, Object> overrides; | |||
There was a problem hiding this comment.
if i get it right this is normally set only once at a time (when the config changes), so maybe make it an AtomicReference ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Memorize override PU props even if the required DataSource is not yet
available. Always merge the memorized props into the static PU props
before publishing an EntityManagerFactory.
We have hold on to the override props although we might not yet be able
to create an EntityManagerFactory, since we will not be notified about
the updated props again.
Resolves: ARIES-1992