Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

c/driver/postgresql: Logging appears downstream #1023

Closed
WillAyd opened this issue Aug 31, 2023 · 2 comments · Fixed by #1027
Closed

c/driver/postgresql: Logging appears downstream #1023

WillAyd opened this issue Aug 31, 2023 · 2 comments · Fixed by #1027
Assignees
@lidavidm
Milestone
ADBC Libraries 0.7.0

Comments

@WillAyd
Copy link
Contributor

WillAyd commented Aug 31, 2023

When running the pandas test suite with ADBC drivers users currently see this output:

pandas/tests/io/test_sql.py .........NOTICE:  table "test_frame" does not exist, skipping
.........FNOTICE:  table "test_frame" does not exist, skipping
x.........NOTICE:  table "test_frame" does not exist, skipping
..........NOTICE:  table "test_frame" does not exist, skipping
..........NOTICE:  table "test_frame" does not exist, skipping
..........NOTICE:  table "test_frame" does not exist, skipping
..........NOTICE:  table "test_frame" does not exist, skipping
..........NOTICE:  table "test_frame" does not exist, skipping
...................xNOTICE:  table "test_frame" does not exist, skipping
x........WARNING:  there is no transaction in progress
..........WARNING:  there is no transaction in progress
.....................NOTICE:  table "test_frame" does not exist, skipping
.........xNOTICE:  table "test_frame" does not exist, skipping
x...............xNOTICE:  table "test_frame" does not exist, skipping
x.....................................................................................................................................................................ss..............x...................................................................x..................................................................F.............................................................................

Would be nice if those didn't appear downstream
@lidavidm
Copy link
Member

We need to add a notice handler to libpq

@lidavidm lidavidm added this to the ADBC Libraries 0.7.0 milestone Aug 31, 2023
@lidavidm lidavidm changed the title [C]: Logging appears downstream c/driver/postgresql: Logging appears downstream Sep 1, 2023
@lidavidm lidavidm self-assigned this Sep 1, 2023
@lidavidm
Copy link
Member

lidavidm commented Sep 1, 2023

I'm just going to suppress it for now (perhaps with an env var to allow it through), with the idea that somewhere between #735 and #924 we'll expose it in the actual driver logs

lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Sep 1, 2023
@lidavidm
fix(c/driver/postgresql): suppress console spam
979e955 
Fixes apache#1023.
@lidavidm lidavidm mentioned this issue Sep 1, 2023
Merged
lidavidm added a commit that referenced this issue Sep 1, 2023
@lidavidm
fix(c/driver/postgresql): suppress console spam (#1027)
3d1d6cc 
Fixes #1023.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidavidm lidavidm

Labels
None yet
Projects
None yet
Milestone
ADBC Libraries 0.7.0
Development

Successfully merging a pull request may close this issue.

fix(c/driver/postgresql): suppress console spam lidavidm/arrow-adbc
2 participants
@lidavidm @WillAyd