Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c/driver/sqlite: ADBC_INGEST_OPTION_MODE_REPLACE is an "Invalid statement option" #1355

Closed
Tracked by #1490
nbenn opened this issue Dec 15, 2023 · 2 comments · Fixed by #1603
Closed
Tracked by #1490

c/driver/sqlite: ADBC_INGEST_OPTION_MODE_REPLACE is an "Invalid statement option" #1355

nbenn opened this issue Dec 15, 2023 · 2 comments · Fixed by #1603
Assignees

Comments

@nbenn
Copy link
Collaborator

nbenn commented Dec 15, 2023

As this was only added in 1.1.0, I assume this means that the SQLite Driver is not on 1.1.0 yet. Is there a rough eta on that?

In oder to have behavior that is conditional on driver API version, is there a way for getting this info pre 1.1.0? I assume that with addition of ADBC_INFO_DRIVER_ADBC_VERSION in 1.1.0, this'd be the way going forward.

ADBC_INFO_DRIVER_VERSION for SQLite currently is "(unknown)", but I assume this (given the addition of ADBC_INFO_DRIVER_ADBC_VERSION), this is intended to hold yet another version number.

case ADBC_INFO_DRIVER_VERSION:
// TODO(lidavidm): fill in driver version
RAISE_ADBC(
AdbcConnectionGetInfoAppendString(array, info_codes[i], "(unknown)", error));
break;

@nbenn nbenn changed the title c/driver/sqlite: `ADBC_INGEST_OPTION_MODE_REPLACE is an "Invalid statement option" c/driver/sqlite: ADBC_INGEST_OPTION_MODE_REPLACE is an "Invalid statement option" Dec 15, 2023
@nbenn nbenn changed the title c/driver/sqlite: ADBC_INGEST_OPTION_MODE_REPLACE is an "Invalid statement option" c/driver/sqlite: ADBC_INGEST_OPTION_MODE_REPLACE is an "Invalid statement option" Dec 15, 2023
@lidavidm
Copy link
Member

It's not in my time budget for the foreseeable future. Maybe Dewey or Matt could chime in.

@lidavidm
Copy link
Member

lidavidm commented Mar 8, 2024

I'll tackle this and similar issues in #1603 or soon after

lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Mar 14, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Mar 14, 2024
@lidavidm lidavidm self-assigned this Mar 14, 2024
@github-actions github-actions bot added this to the ADBC Libraries 0.11.0 milestone Mar 14, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Mar 14, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Mar 14, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Mar 14, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Mar 14, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Mar 14, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Mar 14, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Mar 14, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Mar 14, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Mar 15, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Mar 15, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Mar 15, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Mar 15, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Mar 15, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Mar 15, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Mar 15, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Mar 15, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Mar 15, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Mar 15, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Mar 15, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Mar 15, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Mar 15, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants