Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/adbc/drivermgr: SIGSEGV on error return #1476

Closed
ukclivecox opened this issue Jan 21, 2024 · 3 comments · Fixed by #1586
Closed

go/adbc/drivermgr: SIGSEGV on error return #1476

ukclivecox opened this issue Jan 21, 2024 · 3 comments · Fixed by #1586
Assignees
@lidavidm
Labels
Type: bug Something isn't working
Milestone
ADBC Libraries 0....

Comments

@ukclivecox
Copy link
Contributor 

SIGSEGV: segmentation violation
PC=0x0 m=20 sigcode=1
signal arrived during cgo execution

goroutine 17503 [syscall]:
runtime.cgocall(0xfe2f30, 0xc0049cbba0)
	/usr/local/go/src/runtime/cgocall.go:157 +0x4b fp=0xc0049cbb78 sp=0xc0049cbb40 pc=0x40b20b
github.com/apache/arrow-adbc/go/adbc/drivermgr._Cfunc_releaseErr(0xc004a863c0)
	_cgo_gotypes.go:623 +0x3f fp=0xc0049cbba0 sp=0xc0049cbb78 pc=0xcbfc3f
github.com/apache/arrow-adbc/go/adbc/drivermgr.toAdbcError.func1(0xc004a863c0?)
	/go/pkg/mod/github.com/apache/arrow-adbc/go/adbc@v0.0.0-20240119160954-3aa0d1216976/drivermgr/wrapper.go:123 +0x34 fp=0xc0049cbbd8 sp=0xc0049cbba0 pc=0xcc06b4
github.com/apache/arrow-adbc/go/adbc/drivermgr.toAdbcError(0x9, 0xc004a863c0)
	/go/pkg/mod/github.com/apache/arrow-adbc/go/adbc@v0.0.0-20240119160954-3aa0d1216976/drivermgr/wrapper.go:123 +0x9c fp=0xc0049cbc10 sp=0xc0049cbbd8 pc=0xcc063c
github.com/apache/arrow-adbc/go/adbc/drivermgr.(*stmt).ExecuteUpdate(0x15f4140?, {0x12dad1a?, 0xc001b94000?})
	/go/pkg/mod/github.com/apache/arrow-adbc/go/adbc@v0.0.0-20240119160954-3aa0d1216976/drivermgr/wrapper.go:442 +0x55 fp=0xc0049cbc50 sp=0xc0049cbc10 pc=0xcc39d5

I've seen this before when errors are percolated back they cause a SIGSEGV.

This is with master, but also happens on 0.9.0.
@lidavidm
Copy link
Member

Which driver/is there a reproducer?

@lidavidm lidavidm added this to the ADBC Libraries 0.10.0 milestone Jan 21, 2024
@lidavidm lidavidm added the Type: bug Something isn't working label Feb 29, 2024
@lidavidm lidavidm removed this from the ADBC Libraries 0.11.0 milestone Mar 1, 2024
@lidavidm lidavidm mentioned this issue Mar 1, 2024
Closed
@lidavidm
Copy link
Member

lidavidm commented Mar 1, 2024

Ok, I can guess at what's happening here at least. We should be checking whether the error is actually initialized.

@lidavidm lidavidm self-assigned this Mar 1, 2024
@lidavidm lidavidm added this to the ADBC Libraries 0.11.0 milestone Mar 1, 2024
@lidavidm lidavidm changed the title go/adbc/driver: SIGSEGV on error return go/adbc/drivermgr: SIGSEGV on error return Mar 2, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Mar 2, 2024
@lidavidm
fix(go/adbc/drivermgr): don't call potentially nil pointer
9a5253e 
Fixes apache#1476.
@lidavidm lidavidm mentioned this issue Mar 2, 2024
Merged
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Mar 2, 2024
@lidavidm
fix(go/adbc/drivermgr): don't call potentially nil pointer
eb5c77b 
Fixes apache#1476.
lidavidm added a commit that referenced this issue Mar 4, 2024
@lidavidm
fix(go/adbc/drivermgr): don't call potentially nil pointer (#1586)
bf42dc6 
Fixes #1476.
@ukclivecox
Copy link
Contributor Author

Thanks @lidavidm !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidavidm lidavidm

Labels
Type: bug Something isn't working
Projects
None yet
Milestone
ADBC Libraries 0.11.0
Development

Successfully merging a pull request may close this issue.

fix(go/adbc/drivermgr): don't call potentially nil pointer lidavidm/arrow-adbc
2 participants
@lidavidm @ukclivecox