Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix title check again #1658

Closed
lidavidm opened this issue Mar 25, 2024 · 0 comments · Fixed by #1661
Closed

ci: fix title check again #1658

lidavidm opened this issue Mar 25, 2024 · 0 comments · Fixed by #1661
Assignees
@lidavidm
Labels
Type: enhancement New feature or request
Milestone
ADBC Libraries 0....

Comments

@lidavidm
Copy link
Member

lidavidm commented Mar 25, 2024 •
edited
Loading

What feature or improvement would you like to see?

The original pull_request_target trigger is better since it reacts to changes in the title, while pull_request doesn't (even when manually re-run). We just need to find a way to check out the PR in the pull_request_target trigger.
@lidavidm lidavidm added the Type: enhancement New feature or request label Mar 25, 2024
@lidavidm lidavidm added this to the ADBC Libraries 0.11.0 milestone Mar 25, 2024
@lidavidm lidavidm self-assigned this Mar 25, 2024
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Mar 25, 2024
@lidavidm
ci: fix PR title checker
89383f5 
Fixes apache#1658.
@lidavidm lidavidm mentioned this issue Mar 25, 2024
Merged
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Mar 25, 2024
@lidavidm
ci: fix PR title checker
4c42b61 
Fixes apache#1658.
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Mar 25, 2024
@lidavidm
ci: fix PR title checker
16fe2be 
Fixes apache#1658.
lidavidm added a commit that referenced this issue Mar 25, 2024
@lidavidm
ci: fix PR title checker (#1661)
bc26d55 
Fixes #1658.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidavidm lidavidm

Labels
Type: enhancement New feature or request
Projects
None yet
Milestone
ADBC Libraries 0.11.0
Development

Successfully merging a pull request may close this issue.

ci: fix PR title checker lidavidm/arrow-adbc
1 participant
@lidavidm