Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

csharp/src/Apache.Arrow.Adbc/C: correctly handle null driver entries for imported drivers #1811

Closed
CurtHagenlocher opened this issue May 3, 2024 · 0 comments · Fixed by #1812
Closed

csharp/src/Apache.Arrow.Adbc/C: correctly handle null driver entries for imported drivers #1811

CurtHagenlocher opened this issue May 3, 2024 · 0 comments · Fixed by #1812
Assignees
@CurtHagenlocher
Labels
Type: bug Something isn't working
Milestone
ADBC Libraries 12

Comments

@CurtHagenlocher
Copy link
Contributor

What happened?

If there's a null in one of the driver function pointers the imported driver should handle this gracefully rather than failing with an access violation. Alternatively, we could require the driver manager for imported drivers but it's not clear at this point that the extra dependency gains us anything.

How can we reproduce the bug?

No response

Environment/Setup

No response
@CurtHagenlocher CurtHagenlocher added the Type: bug Something isn't working label May 3, 2024
@CurtHagenlocher CurtHagenlocher self-assigned this May 3, 2024
CurtHagenlocher added a commit to CurtHagenlocher/arrow-adbc that referenced this issue May 3, 2024
@CurtHagenlocher
Validates that required function pointers are present in an imported …
df1c2df 
…driver and backfills optional functions to return ADBC_STATUS_NOT_IMPLEMENTED.

Closes apache#1811
@CurtHagenlocher CurtHagenlocher mentioned this issue May 3, 2024
Merged
@github-actions github-actions bot added this to the ADBC Libraries 1.0.0 milestone May 3, 2024
lidavidm pushed a commit that referenced this issue May 4, 2024
@CurtHagenlocher
fix(csharp/src/Apache.Arrow.Adbc/C): correctly handle null driver ent…
8ac7304 
…ries for imported drivers (#1812)

Validates that required function pointers are present in an imported
driver and backfills optional functions to return
ADBC_STATUS_NOT_IMPLEMENTED.

Closes #1811
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CurtHagenlocher CurtHagenlocher

Labels
Type: bug Something isn't working
Projects
None yet
Milestone
ADBC Libraries 12
1 participant
@CurtHagenlocher