rust: fix new clippy lints #3075
Description
What happened?
A stable Rust update brought new lints.
Stack Trace
error: variables can be used directly in the `format!` string
--> core/src/options.rs:624:17
|
624 | format!("Unknown standard statistic key: {}", value),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: `-D clippy::uninlined-format-args` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::uninlined_format_args)]`
help: change this to
|
624 - format!("Unknown standard statistic key: {}", value),
624 + format!("Unknown standard statistic key: {value}"),
|
error: implicit autoref creates a reference to the dereference of a raw pointer
--> core/src/driver_exporter.rs:1635:23
|
1635 | let key = (*private_data).keys[index].as_ptr();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: creating a reference requires the pointer target to be valid and imposes aliasing requirements
= note: `-D dangerous-implicit-autorefs` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(dangerous_implicit_autorefs)]`
help: try using a raw pointer method instead; or if this reference is intentional, make it explicit
|
1635 | let key = (&(*private_data).keys)[index].as_ptr();
| ++ +
error: implicit autoref creates a reference to the dereference of a raw pointer
--> core/src/driver_exporter.rs:1636:25
|
1636 | let value = (*private_data).values[index].as_ptr();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: creating a reference requires the pointer target to be valid and imposes aliasing requirements
help: try using a raw pointer method instead; or if this reference is intentional, make it explicit
|
1636 | let value = (&(*private_data).values)[index].as_ptr();
| ++ +
error: implicit autoref creates a reference to the dereference of a raw pointer
--> core/src/driver_exporter.rs:1637:32
|
1637 | let value_length = (*private_data).values[index].len();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: creating a reference requires the pointer target to be valid and imposes aliasing requirements
help: try using a raw pointer method instead; or if this reference is intentional, make it explicit
|
1637 | let value_length = (&(*private_data).values)[index].len();
| ++ +
error: could not compile `adbc_core` (lib) due to 4 previous errors
warning: build failed, waiting for other jobs to finish...
How can we reproduce the bug?
No response
Environment/Setup
No response