Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

java/driver/jdbc: add a hook to customize type conversions #720

Closed
lidavidm opened this issue May 31, 2023 · 0 comments · Fixed by #722
Closed

java/driver/jdbc: add a hook to customize type conversions #720

lidavidm opened this issue May 31, 2023 · 0 comments · Fixed by #722
Assignees
@lidavidm
Milestone
ADBC Libraries 0.5.0

Comments

@lidavidm
Copy link
Member

We can integration test against PostgreSQL which should have fairly good support.

We may also want to test MySQL or SQL Server.

Any things may have to be fixed upstream.
@lidavidm lidavidm added this to the ADBC Libraries 0.5.0 milestone May 31, 2023
@lidavidm lidavidm self-assigned this May 31, 2023
This was referenced May 31, 2023
Merged
Closed
@lidavidm lidavidm changed the title java/driver/jdbc: make sure types are all converted properly to Arrow java/driver/jdbc: add a hook to customize type conversions Jun 6, 2023
lidavidm added a commit that referenced this issue Jun 7, 2023
@lidavidm
feat(java/driver/jdbc): add hooks for JDBC type system mapping (#722)
ed2b280 
- Adds a custom option to the ADBC JDBC adapter to provide a custom type
mapper from JDBC column info to ArrowType
- Adds a customized JdbcFieldInfo that exposes more fields that are
necessary (e.g. PostgreSQL's JDBC driver exposes `TIMESTAMP WITHOUT TIME
ZONE` and `TIMESTAMP WITH TIME ZONE` as `Types.TIMESTAMP`, so you have
to look at the type name instead)
- Future work: #728
- Future work: apache/arrow#35916
- Future work: #727
- Add (failing) tests demonstrating that the values read are
inconsistent with the assumed types

Fixes #720.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidavidm lidavidm

Labels
None yet
Projects
None yet
Milestone
ADBC Libraries 0.5.0
Development

Successfully merging a pull request may close this issue.

feat(java/driver/jdbc): add hooks for JDBC type system mapping lidavidm/arrow-adbc
1 participant
@lidavidm