Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

c/driver/sqlite: Syntax error using keywords in ingestion #905

Closed
WillAyd opened this issue Jul 14, 2023 · 1 comment · Fixed by #906
Closed

c/driver/sqlite: Syntax error using keywords in ingestion #905

WillAyd opened this issue Jul 14, 2023 · 1 comment · Fixed by #906
Milestone
ADBC Libraries 0.6.0

Comments

@WillAyd
Copy link
Contributor

WillAyd commented Jul 14, 2023

Working through pandas integration the ADBC driver would commonly emit something like CREATE TABLE test (index, A, B, C, D) and the driver would return a syntax error. index is a reserved sqlite keyword and when removing that column there is no issue; think the driver should quote these values on table create

https://www.sqlite.org/lang_keywords.html
@lidavidm lidavidm changed the title sqlite Syntax error using Keyword c/driver/sqlite: Syntax error using keywords in ingestion Jul 14, 2023
@lidavidm
Copy link
Member

D'oh. Yeah, we should quote all names.

This was referenced Jul 14, 2023
Merged
Merged
@lidavidm lidavidm added this to the ADBC Libraries 0.6.0 milestone Jul 17, 2023
lidavidm pushed a commit that referenced this issue Jul 17, 2023
@WillAyd
fix(c/driver/sqlite): fix escaping of sqlite TABLE CREATE columns (#906)
1a07f24 
Should maybe use sqlite3's string handling throughout the module; for
now just focused on CREATE TABLE

fixes
#905 (comment)
@lidavidm lidavidm mentioned this issue Aug 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ADBC Libraries 0.6.0
Development

Successfully merging a pull request may close this issue.

fix(c/driver/sqlite): fix escaping of sqlite TABLE CREATE columns WillAyd/arrow-adbc
2 participants
@lidavidm @WillAyd