Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(c/driver): support target catalog/schema for ingestion #1056

Merged
merged 4 commits into from
Sep 12, 2023
Merged

feat(c/driver): support target catalog/schema for ingestion #1056

merged 4 commits into from
Sep 12, 2023

Conversation

lidavidm
Copy link
Member

  • Support target catalog/schema options for ingestion
  • Fix escaping in SQLite, PostgreSQL

Fixes #1000.

@lidavidm
feat(c/driver): support target catalog/schema for ingestion
f8f62b2 
- Support target catalog/schema options for ingestion
- Fix escaping in SQLite, PostgreSQL

Fixes apache#1000.
@lidavidm lidavidm added this to the ADBC Libraries 0.7.0 milestone Sep 12, 2023
@lidavidm lidavidm mentioned this pull request Sep 12, 2023
Merged
@lidavidm lidavidm merged commit db39236 into apache:main Sep 12, 2023
65 checks passed
@lidavidm lidavidm deleted the gh-1000 branch September 12, 2023 19:40
@alexander-beedie
Copy link

alexander-beedie commented Sep 26, 2023 •
edited
Loading

Hmm; was trying to integrate these changes into our write_database functionality, but tests are showing that while SQLite can now be made to work, I'm unable to write into anything other than the public schema for PostgreSQL, irrespective of the value of db_schema_name 🤔

I'll create an issue with a fresh example.

Update: see #1109.

@alexander-beedie alexander-beedie mentioned this pull request Sep 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paleolimbot paleolimbot Awaiting requested review from paleolimbot paleolimbot is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ADBC Libraries 0.7.0
2 participants
@lidavidm @alexander-beedie