-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(c/driver/postgresql): Use COPY for writes #1093
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
d685042
first build
WillAyd e5f559a
hacked together
WillAyd 2002e78
working with ArrowBuffer
WillAyd ff6c03a
dedicated ExecuteCopy method
WillAyd 1939483
Add ExecuteCopy method
WillAyd 95d4ba0
Merge remote-tracking branch 'upstream/main' into copy-writer
WillAyd 4c9bc6c
Update to use CopyWriter
WillAyd b42feea
Merge branch 'main' into copy-writer
WillAyd 96b7796
updated IngestError test
WillAyd 95094d2
use unique_ptr
WillAyd e032f55
factory func cleanup
WillAyd 1ae2e48
zero initialize
WillAyd e732ef7
nullptr assignment
WillAyd 39492a2
Merge branch 'main' into copy-writer
WillAyd 35452fc
change benchmark iterations
WillAyd 671a6ae
benchmark improvements
WillAyd d8fdeca
release error
WillAyd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2112,7 +2112,8 @@ void StatementTest::TestSqlIngestErrors() { | |
{"coltwo", NANOARROW_TYPE_INT64}}), | ||
IsOkErrno()); | ||
ASSERT_THAT( | ||
(MakeBatch<int64_t, int64_t>(&schema.value, &array.value, &na_error, {}, {})), | ||
(MakeBatch<int64_t, int64_t>(&schema.value, &array.value, &na_error, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like postgres COPY only raises if there is data
Given the format itself sends the number of columns expected row-by-row; in the empty result case no such communication occurs |
||
{-42}, {-42})), | ||
IsOkErrno(&na_error)); | ||
|
||
ASSERT_THAT(AdbcStatementBind(&statement, &array.value, &schema.value, &error), | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are orthogonal but figured OK to lump in here given this is the first PR using these benchmarks. Also happy to split off if you prefer
I noticed LSAN is not happy if we actually return now, for example if you provide an invalid test_uri. Am I missing something extra I should be releasing before these returns?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's because the error needs to be released.
If we're not going to use the error, we could just not have it in the first place (it should always be OK to pass
nullptr
to an error argument)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah OK. Probably makes sense to just use the error message instead. Done that simplisticly for now - can make into a macro in a follow up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, Dewey's original suggestion of factoring it out into a single function would also work.