Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dev/release): install missing protobuf for Python test #1264

Merged
merged 1 commit into from
Nov 7, 2023
Merged

fix(dev/release): install missing protobuf for Python test #1264

merged 1 commit into from
Nov 7, 2023

Conversation

kou
Copy link
Member

@kou kou commented Nov 7, 2023

Fixes #1263.

@kou kou requested a review from lidavidm as a code owner November 7, 2023 02:34
lidavidm
lidavidm approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lidavidm lidavidm merged commit 0bae296 into apache:main Nov 7, 2023
7 checks passed
@lidavidm lidavidm added this to the ADBC Libraries 0.9.0 milestone Nov 7, 2023
@kou kou deleted the release-python-protobuf branch November 7, 2023 20:59
vleslief-ms pushed a commit to vleslief-ms/arrow-adbc that referenced this pull request Nov 9, 2023
@kou @vleslief-ms
fix(dev/release): install missing protobuf for Python test (apache#1264)
3b5768c 
Fixes apache#1263.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidavidm lidavidm lidavidm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ADBC Libraries 0.9.0
Development

Successfully merging this pull request may close these issues.

release: test_python misses protobuf dependency
2 participants
@kou @lidavidm