feat(go/adbc/drivermgr): Implement Remaining CGO Wrapper Methods that are Supported by SQLite Driver #1304
Conversation
| @@ -186,6 +190,19 @@ func getRdr(out *C.struct_ArrowArrayStream) (array.RecordReader, error) { | |||
| return rdr.(array.RecordReader), nil | |||
| } | |||
|
|
|||
| func getSchema(out *C.struct_ArrowSchema) (*arrow.Schema, error) { | |||
| // Maybe: ImportCArrowSchema should perform this check? | |||
There was a problem hiding this comment.
This check is needed for when catalog or dbSchema is specified for GetTableSchema. The SQLite driver does not return a schema when either of these are set. As a result, we attempt to import a schema through the cdata interface with all nil fields including format which panics when it reaches this line.
It does seem like it would be helpful to perform these nil checks in the cdata package, but I just wanted to check first as that would require cross-repo changes and add to the scope of these changes.
| expSchema := arrow.NewSchema( | ||
| []arrow.Field{ | ||
| {Name: "id", Type: arrow.PrimitiveTypes.Int64, Nullable: true}, | ||
| {Name: "name", Type: arrow.PrimitiveTypes.Int64, Nullable: true}, // Should be arrow.BinaryTypes.String |
There was a problem hiding this comment.
I would have expected the SQLite type TEXT to map to arrow.BinaryTypes.String. I've confirmed via the SQLite driver separately (see screenshot) that this is in fact the behavior of the current driver implementation, so this test actually does indicate the correct behavior for the CGO wrapper.
There was a problem hiding this comment.
SQLite doesn't have types. So the only thing the driver can do is try to read some rows and infer an appropriate column type.
There was a problem hiding this comment.
Thanks @lidavidm, I didn't realize that. This now works as expected after inserting test data.
What?
Implementations for the following methods in the CGO wrapper for
adbc_driver_manager:GetTableSchemaGetTableTypesCommitRollbackGetParameterSchemaBindStreamWhy?
Functionality exists in C++ driver manager but not yet accessible via Go driver interface.
Notes
Three methods in the wrapper remain unimplemented:
ExecutePartitions,ReadPartition, andSetSubstraitPlan. These methods are not currently supported by the SQLite driver, which is the primary test target for these changes. It is still possible to implement them in the drivermgr wrapper without support in specific drivers, but it does make it more difficult to verify correct behavior. The effort to add those methods will likely involve some additional work to ensure we are able to test their behaviors, so they are being left out of this current round of implementations.Closes part of: #1291