fix(go/adbc/driver/snowflake): Removing SQL injection to get table name with special character for getObjectsTables #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnithaPanduranganMS
requested review from
zeroshade and
lidavidm
as code owners
zeroshade
reviewed
Dec 4, 2023
zeroshade
reviewed
Dec 4, 2023
jduo
reviewed
Dec 5, 2023
jduo
reviewed
Dec 5, 2023
Added test in C# driver test |
ryan-syed
suggested changes
Dec 7, 2023
| @@ -828,7 +836,7 @@ func (c *cnxn) GetTableSchema(ctx context.Context, catalog *string, dbSchema *st | |||
| if dbSchema != nil { | |||
| tblParts = append(tblParts, strconv.Quote(strings.ToUpper(*dbSchema))) | |||
| } | |||
| tblParts = append(tblParts, strconv.Quote(strings.ToUpper(tableName))) | |||
There was a problem hiding this comment.
Should string.ToUpper conversion be avoided for catalog and schema name too?
zeroshade
reviewed
Dec 11, 2023
|
This all LGTM, I second @ryan-syed's comments for adding some tests for special characters and avoiding the |
|
Implemented on top of #1352 (perf(go/adbc/driver/snowflake): Reduced SQL calls in GetObjects to two, added prefixing DbName for INFORMATION_SCHEMA) |
|
@AnithaPanduranganMS do you mind rebasing? |
…_getobjects_double_quoted_identifier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Solution:
Testing:
Fixes #1225