fix(java/driver/jdbc): fix connection leak in JdbcDataSourceDatabase constructor
#1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rtadepalli
changed the title
JdbcDataSourceDatabase constructor and pass in username/pass while getting connectionJdbcDataSourceDatabase constructor and pass in username/pass while getting connection
…in username/pass while getting connection
rtadepalli
force-pushed
the
check-username-before-conn
branch
from
f7ee0c9
to
2d287fc
Compare
rtadepalli
changed the title
JdbcDataSourceDatabase constructor and pass in username/pass while getting connectionJdbcDataSourceDatabase constructor
lidavidm
changed the title
JdbcDataSourceDatabase constructor JdbcDataSourceDatabase constructor
lidavidm
approved these changes
Jan 2, 2024
|
Can we add a unit test? It could also be an integration test with Postgres. |
|
I've merged this for now, we can follow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there is a connection leak in the constructor for
JdbcDataSourceDatabasewhere we're obtaining a connection in the constructor but we're obtaining another one in theconnectmethod using the appropriate username/password. We can remove this and fix the bug as described in #1415.Fixes #1415.