feat(go/adbc/driver/flightsql): enable incremental queries #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
force-pushed
the
gh1451
branch
4 times, most recently
from
579d656
to
7b7477e
Compare
lidavidm
added a commit
to apache/arrow
that referenced
this pull request
Jan 19, 2024
### Rationale for this change It's impossible to use the current bindings with PollFlightInfo. Required for apache/arrow-adbc#1457. ### What changes are included in this PR? Add new methods that expose PollFlightInfo. ### Are these changes tested? Yes ### Are there any user-facing changes? Adds new methods. * Closes: #39574 Authored-by: David Li <li.davidm96@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
lidavidm
force-pushed
the
gh1451
branch
2 times, most recently
from
470db9a
to
f2accba
Compare
|
CC @zeroshade |
zeroshade
reviewed
Jan 19, 2024
| @@ -132,6 +153,9 @@ type statement struct { | |||
| prepared *flightsql.PreparedStatement | |||
| queueSize int | |||
| timeouts timeoutOption | |||
| // TODO: this needs to be cleared at appropriate times | |||
There was a problem hiding this comment.
should we create a corresponding issue to make sure we don't forget to do this?
There was a problem hiding this comment.
Ah, I meant to do this before opening it, thanks. I've updated it so that entrypoints reset the incremental execution state where appropriate.
zeroshade
reviewed
Jan 19, 2024
Comment on lines
553
to
589
| if s.prepared != nil { | ||
| poll, err = s.prepared.ExecutePoll(ctx, s.incrementalState.retryDescriptor, grpc.Header(&header), grpc.Trailer(&trailer), s.timeouts) | ||
| } else { | ||
| poll, err = s.query.poll(ctx, s.cnxn, s.incrementalState.retryDescriptor, grpc.Header(&header), grpc.Trailer(&trailer), s.timeouts) | ||
| } |
There was a problem hiding this comment.
It feels like this would be better as a helper method on s to make this easier to read
zeroshade
reviewed
Jan 19, 2024
| Code: adbc.StatusInternal, | ||
| } | ||
| } | ||
| info = &flight.FlightInfo{ |
There was a problem hiding this comment.
Could we just use https://pkg.go.dev/google.golang.org/protobuf@v1.32.0/proto#Clone instead?
|
Looks good in general other than a few comments / nitpicks |
soumyadsanyal
pushed a commit
to soumyadsanyal/arrow-adbc
that referenced
this pull request
Jan 31, 2024
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
### Rationale for this change It's impossible to use the current bindings with PollFlightInfo. Required for apache/arrow-adbc#1457. ### What changes are included in this PR? Add new methods that expose PollFlightInfo. ### Are these changes tested? Yes ### Are there any user-facing changes? Adds new methods. * Closes: apache#39574 Authored-by: David Li <li.davidm96@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Feb 28, 2024
### Rationale for this change It's impossible to use the current bindings with PollFlightInfo. Required for apache/arrow-adbc#1457. ### What changes are included in this PR? Add new methods that expose PollFlightInfo. ### Are these changes tested? Yes ### Are there any user-facing changes? Adds new methods. * Closes: apache#39574 Authored-by: David Li <li.davidm96@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this pull request
Mar 8, 2024
### Rationale for this change It's impossible to use the current bindings with PollFlightInfo. Required for apache/arrow-adbc#1457. ### What changes are included in this PR? Add new methods that expose PollFlightInfo. ### Are these changes tested? Yes ### Are there any user-facing changes? Adds new methods. * Closes: apache#39574 Authored-by: David Li <li.davidm96@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
kou
pushed a commit
to apache/arrow-go
that referenced
this pull request
Aug 30, 2024
### Rationale for this change It's impossible to use the current bindings with PollFlightInfo. Required for apache/arrow-adbc#1457. ### What changes are included in this PR? Add new methods that expose PollFlightInfo. ### Are these changes tested? Yes ### Are there any user-facing changes? Adds new methods. * Closes: #39574 Authored-by: David Li <li.davidm96@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires apache/arrow#39575.
Closes #1451.