Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(r/adbcpostgresql): Link -lcrypt32 on Windows #1471

Merged
merged 1 commit into from
Jan 20, 2024
Merged

fix(r/adbcpostgresql): Link -lcrypt32 on Windows #1471

merged 1 commit into from
Jan 20, 2024

Conversation

paleolimbot
Copy link
Member

As requested by Tomas:

Dear Dewey,

I am sorry to report that your package's Makevars.ucrt needs to be updated for an upcoming release of Rtools: one also has to link crypt32, please see the attached patch.

Please update so that your package will keep working in future versions of Rtools. This can be done unconditionally, because the library was available even before, just wasn't needed - so it should be fine to simply use the patch.

@github-actions github-actions bot added this to the ADBC Libraries 0.10.0 milestone Jan 19, 2024
@paleolimbot paleolimbot marked this pull request as ready for review January 20, 2024 18:41
@paleolimbot paleolimbot merged commit dd7d02d into apache:main Jan 20, 2024
22 checks passed
@paleolimbot paleolimbot deleted the r-postgres-crypt32 branch January 20, 2024 18:42
paleolimbot added a commit to paleolimbot/arrow-adbc that referenced this pull request Jan 20, 2024
@paleolimbot
fix(r/adbcpostgresql): Link -lcrypt32 on Windows (apache#1471)
251f727 
As requested by Tomas:

```
Dear Dewey,

I am sorry to report that your package's Makevars.ucrt needs to be updated for an upcoming release of Rtools: one also has to link crypt32, please see the attached patch.

Please update so that your package will keep working in future versions of Rtools. This can be done unconditionally, because the library was available even before, just wasn't needed - so it should be fine to simply use the patch.
```
soumyadsanyal pushed a commit to soumyadsanyal/arrow-adbc that referenced this pull request Jan 31, 2024
@paleolimbot @soumyadsanyal
fix(r/adbcpostgresql): Link -lcrypt32 on Windows (apache#1471)
55e4b42 
As requested by Tomas:

```
Dear Dewey,

I am sorry to report that your package's Makevars.ucrt needs to be updated for an upcoming release of Rtools: one also has to link crypt32, please see the attached patch.

Please update so that your package will keep working in future versions of Rtools. This can be done unconditionally, because the library was available even before, just wasn't needed - so it should be fine to simply use the patch.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ADBC Libraries 0.10.0
Development

Successfully merging this pull request may close these issues.
1 participant
@paleolimbot