You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To help Snowflake track adoption and usage of the ADBC driver, we can explicitly add a prefix to any client application name to indicate the ADBC driver is the source of the requests.
lidavidm
changed the title
chore(snowflake): add '[ADBC]' to snowflake application name
feat(go/adbc/driver/snowflake): add '[ADBC]' to snowflake application name
Feb 7, 2024
The reason will be displayed to describe this comment to others. Learn more.
Oh, you're trying to override the user choice...do we want that? It seems to make more sense to just pass along the user's application name if set, otherwise set a basic one indicating the driver.
IMO if gosnowflake doesn't prefix we shouldn't either (does it?); and in Go and Python we should set defaults if they're not set by the user (so Snowflake can track the Go/Python drivers otherwise)
gosnowflake has an internal application name that is not externally changeable so regardless of the User's application name, snowflake can track it's coming from the Go driver. So they don't need to prefix
Yeap. We can't get access to that unfortunately. They said the preferred method would be to pass it as the application name or prefix the user's choice.
Yeap. We can't get access to that unfortunately. They said the preferred method would be to pass it as the application name or prefix the user's choice.
Ah, sorry...if they are OK with prefixing the user's choice then I'm ok with that too.
A follow-up to #1525 to add an
R-specific prefix for the Snowflake driver. We could allow this to be
customized, too, but I would prefer to that feature to be requested
before pursuing it.
Closes#1526.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lidavidm
changed the title
To help Snowflake track adoption and usage of the ADBC driver, we can explicitly add a prefix to any client application name to indicate the ADBC driver is the source of the requests.