Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(go/adbc/driver/flightsql): expose FlightInfo during polling #1582

Merged
merged 2 commits into from
Mar 1, 2024
Merged

feat(go/adbc/driver/flightsql): expose FlightInfo during polling #1582

merged 2 commits into from
Mar 1, 2024

Conversation

lidavidm
Copy link
Member

@lidavidm lidavidm commented Mar 1, 2024

Fixes #1571.

@github-actions github-actions bot added this to the ADBC Libraries 0.11.0 milestone Mar 1, 2024
@lidavidm lidavidm marked this pull request as ready for review March 1, 2024 21:19
@lidavidm lidavidm requested a review from zeroshade as a code owner March 1, 2024 21:19
zeroshade
zeroshade approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@zeroshade zeroshade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this all seems good to me though I do admit i didn't go through to ensure we've covered all cases where we'd need to reset it. Just gonna trust you on that one 😄

@lidavidm
Copy link
Member Author

lidavidm commented Mar 1, 2024

Filed #1584 to track down the flaky test

@lidavidm lidavidm merged commit d962961 into apache:main Mar 1, 2024
52 of 54 checks passed
@lidavidm lidavidm deleted the gh-1571 branch March 1, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeroshade zeroshade zeroshade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ADBC Libraries 0.11.0
Development

Successfully merging this pull request may close these issues.

go/adbc/driver/flightsql: provide access to FlightInfo app_metadata
2 participants
@lidavidm @zeroshade