feat(go/adbc/driver/flightsql): support reuse-connection location #1594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroshade
reviewed
Mar 7, 2024
Comment on lines
+72
to
+75
| if loc.Uri == flight.LocationReuseConnection { | ||
| hasFallback = true | ||
| continue | ||
| } |
There was a problem hiding this comment.
shouldn't we break instead of continue? or at least do the same as we do below and attempt to reuse the connection, continuing the loop if it errors, returning if it succeeds?
There was a problem hiding this comment.
What I'm doing is: first try everything except reuse-connection, then if all other alternatives fail, try the original service
There was a problem hiding this comment.
is that correct semantically? We don't want to maintain the order and have it do the reuse-connection before moving on to further locations?
There was a problem hiding this comment.
I think it's always been said that order is unspecified.
There was a problem hiding this comment.
Okay then, I'm fine with this :)
zeroshade
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1588.