feat(dev/release): add C# post-release script #1595
Conversation
|
|
lidavidm
changed the title
|
Could I trouble you to at least update the filenames in the docs, too? https://github.com/apache/arrow-adbc/blob/main/docs/source/development/releasing.rst |
Working on that now David and thank you for the title correction! |
dev/release/post-07-csharp.sh
Outdated
| base_names+=(Apache.Arrow.Adbc.Drivers.BigQuery.${version}) | ||
| base_names+=(Apache.Arrow.Adbc.Drivers.FlightSql.${version}) | ||
| base_names+=(Apache.Arrow.Adbc.Drivers.Interop.Snowflake.${version}) | ||
| for base_name in ${base_names[@]}; do |
There was a problem hiding this comment.
In general, we should use "${array[@]}" form:
| for base_name in ${base_names[@]}; do | |
| for base_name in "${base_names[@]}"; do |
There was a problem hiding this comment.
Applied suggestion
… the release management guide
| base_names+=(Apache.Arrow.Adbc.Drivers.Interop.Snowflake.${version}) | ||
| for base_name in "${base_names[@]}"; do | ||
| dotnet nuget push \ | ||
| ${base_name}.nupkg \ |
There was a problem hiding this comment.
Where do these packages come from?
There was a problem hiding this comment.
Ok, in #1636 I'm adding C# to packaging.yml like all the other builds. Then this script can pull the artifacts from the GitHub release as the other scripts do.
Julian-Brandrick
deleted the
dev/v-jbrandrick/CreatingNuGetPostReleaseScript
branch
post-07-csharp.sh: Uploads Arrow-ADBC NuGet packages to the NuGet.org package manager. Based on the same script from the Arrow repo: dev/release/post-06-csharp.sh
Bumped the indices for other post-release scripts based on the ordering in the Arrow repo.
I packed the Arrow-ADBC csharp folder to get the list of packages to upload and excluded the Test packages:
