Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(go/adbc/driver/snowflake): fix precision/scale in table schema #1656

Merged
merged 1 commit into from
Mar 25, 2024
Merged

fix(go/adbc/driver/snowflake): fix precision/scale in table schema #1656

merged 1 commit into from
Mar 25, 2024

Conversation

ruowan
Copy link
Contributor

@ruowan ruowan commented Mar 25, 2024

No description provided.

@github-actions github-actions bot added this to the ADBC Libraries 0.11.0 milestone Mar 25, 2024
@ruowan ruowan changed the title minor fix for snowflake getSchemaTable error feat(go/adbc/driver/snowflake) minor fix for snowflake getSchemaTable error Mar 25, 2024
@ruowan ruowan changed the title feat(go/adbc/driver/snowflake) minor fix for snowflake getSchemaTable error fix(go/adbc/driver/snowflake) minor fix for snowflake getSchemaTable error Mar 25, 2024
@lidavidm lidavidm changed the title fix(go/adbc/driver/snowflake) minor fix for snowflake getSchemaTable error fix(go/adbc/driver/snowflake): minor fix for snowflake getSchemaTable error Mar 25, 2024
@lidavidm lidavidm changed the title fix(go/adbc/driver/snowflake): minor fix for snowflake getSchemaTable error fix(go/adbc/driver/snowflake): fix precision/scale in table schema Mar 25, 2024
lidavidm
lidavidm approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I'm going to have to fix the title check again

@lidavidm lidavidm merged commit 4e0175f into apache:main Mar 25, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidavidm lidavidm lidavidm approved these changes

@CurtHagenlocher CurtHagenlocher Awaiting requested review from CurtHagenlocher CurtHagenlocher is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ADBC Libraries 0.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ruowan @lidavidm