fix(r): Ensure CXX_STD is set everywhere #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paleolimbot
changed the title
lidavidm
approved these changes
Apr 3, 2024
cocoa-xu
pushed a commit
to cocoa-xu/arrow-adbc
that referenced
this pull request
Apr 12, 2024
Upon submitting adbcpostgresql to CRAN, there is now a build error for R
4.1 on Windows, which uses C++14 as its default standard if unspecified.
This gives:
```
g++ -std=gnu++14 -I"D:/RCompile/recent/R-4.2.3/include" -DNDEBUG -I../src -DADBC_EXPORT="" -D__USE_MINGW_ANSI_STDIO -I"d:/rtools42/x86_64-w64-mingw32.static.posix/include" -pedantic -O2 -Wall -mfpmath=sse -msse2 -mstackrealign -c connection.cc -o connection.o
In file included from connection.cc:37:
result_helper.h:37:8: error: 'optional' in namespace 'std' does not name a template type
37 | std::optional<double> ParseDouble() const {
| ^~~~~~~~
result_helper.h:37:3: note: 'std::optional' is only available from C++17 onwards
```
https://www.r-project.org/nosvn/R.check/r-oldrel-windows-x86_64/adbcpostgresql-00install.html
paleolimbot
added a commit
to paleolimbot/arrow-adbc
that referenced
this pull request
Apr 15, 2024
Upon submitting adbcpostgresql to CRAN, there is now a build error for R
4.1 on Windows, which uses C++14 as its default standard if unspecified.
This gives:
```
g++ -std=gnu++14 -I"D:/RCompile/recent/R-4.2.3/include" -DNDEBUG -I../src -DADBC_EXPORT="" -D__USE_MINGW_ANSI_STDIO -I"d:/rtools42/x86_64-w64-mingw32.static.posix/include" -pedantic -O2 -Wall -mfpmath=sse -msse2 -mstackrealign -c connection.cc -o connection.o
In file included from connection.cc:37:
result_helper.h:37:8: error: 'optional' in namespace 'std' does not name a template type
37 | std::optional<double> ParseDouble() const {
| ^~~~~~~~
result_helper.h:37:3: note: 'std::optional' is only available from C++17 onwards
```
https://www.r-project.org/nosvn/R.check/r-oldrel-windows-x86_64/adbcpostgresql-00install.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon submitting adbcpostgresql to CRAN, there is now a build error for R 4.1 on Windows, which uses C++14 as its default standard if unspecified. This gives:
https://www.r-project.org/nosvn/R.check/r-oldrel-windows-x86_64/adbcpostgresql-00install.html