Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(glib): Add garrow_connection_get_statistics() #1744

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

kou
Copy link
Member

@kou kou commented Apr 22, 2024

Fixes #1743.

We use PostgreSQL instead of SQLite for testing. Because the SQLite driver doesn't support GetStatistics yet.

Fixes apache#1743.

We use PostgreSQL instead of SQLite for testing. Because the SQLite
driver doesn't support GetStatistics yet.
@github-actions github-actions bot added this to the ADBC Libraries 1.0.0 milestone Apr 22, 2024
@kou
Copy link
Member Author

kou commented Apr 22, 2024

Can we install PostgreSQL to test the GLib bindings?

diff --git a/ci/conda_env_glib.txt b/ci/conda_env_glib.txt
index cd937ee22..883ff7f92 100644
--- a/ci/conda_env_glib.txt
+++ b/ci/conda_env_glib.txt
@@ -19,4 +19,5 @@ arrow-c-glib
 glib
 gobject-introspection
 meson
+postgresql
 ruby

@kou kou requested a review from lidavidm as a code owner April 22, 2024 21:31
@kou
Copy link
Member Author

kou commented Apr 22, 2024

Ubuntu:

https://github.com/apache/arrow-adbc/actions/runs/8791195500/job/24125145486?pr=1744#step:10:43

35 tests, 41 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications

macOS:

https://github.com/apache/arrow-adbc/actions/runs/8791195500/job/24125145167?pr=1744#step:10:43

35 tests, 41 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications

No omissions. Added tests are executed.

Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lidavidm lidavidm merged commit c0bf4bd into apache:main Apr 22, 2024
55 checks passed
@kou kou deleted the glib-statistics branch April 23, 2024 00:25
cocoa-xu pushed a commit to cocoa-xu/arrow-adbc that referenced this pull request Apr 24, 2024
Fixes apache#1743.

We use PostgreSQL instead of SQLite for testing. Because the SQLite
driver doesn't support GetStatistics yet.
davidhcoe pushed a commit to davidhcoe/arrow-adbc that referenced this pull request Apr 25, 2024
Fixes apache#1743.

We use PostgreSQL instead of SQLite for testing. Because the SQLite
driver doesn't support GetStatistics yet.
cocoa-xu pushed a commit to meowcraft-dev/arrow-adbc that referenced this pull request May 8, 2024
Fixes apache#1743.

We use PostgreSQL instead of SQLite for testing. Because the SQLite
driver doesn't support GetStatistics yet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

glib: add garrow_connection_get_statistics()
2 participants