fix(go/adbc/driver/flightsql): should use ctx.Err().Error()
#1769
Conversation
|
@cocoa-xu looks like you need to update some of the python tests which were expecting specific error text results which are being changed by this |
|
Sorry but I didn't find there're any tests (in fact any code) that are expecting any error message that is (or contains) Plus, even if there're some tests that should be updated because of the changes made here, it doesn't make sense that only Python 3.9 (and perhaps Python 3.11) failed on Furthermore, the same test also failed in other CI runs, https://github.com/apache/arrow-adbc/actions/runs/8843931798/job/24285879645#step:14:1213, in PR #1762. It's unlikely that the changes in this PR has caused the above failed CI jobs. |
|
@zeroshade there's something in the Flight SQL client that is treating io.EOF as an actual error, I think |
…#1769) As pointed out by @zeroshade [here](apache#1722 (comment)), this should be handled by doing `adbc.Error{Msg: ctx.Err(), Code:....}`.
As pointed out by @zeroshade here, this should be handled by doing
adbc.Error{Msg: ctx.Err(), Code:....}.