Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(csharp): Implement remaining functions in 1.0 spec #1773

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

CurtHagenlocher
Copy link
Contributor

Implements the remaining functions in the 1.0 specification in the C interop layer.

Closes #1221

@github-actions github-actions bot added this to the ADBC Libraries 1.0.0 milestone Apr 25, 2024
@CurtHagenlocher CurtHagenlocher changed the title Implement remaining functions in 1.0 spec. feat(csharp): Implement remaining functions in 1.0 spec Apr 25, 2024
@@ -17,14 +17,13 @@

using System;
using System.Collections.Generic;
using System.Diagnostics;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two Debug.Asserts in the change.

@CurtHagenlocher CurtHagenlocher merged commit 71072e0 into apache:main Apr 25, 2024
6 checks passed
@CurtHagenlocher CurtHagenlocher deleted the GH-1221 branch April 29, 2024 14:17
cocoa-xu pushed a commit to meowcraft-dev/arrow-adbc that referenced this pull request May 8, 2024
Implements the remaining functions in the 1.0 specification in the C
interop layer.

Closes apache#1221
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(csharp): implement remaining functions in 1.0 spec
2 participants