feat(go/adbc/driver/snowflake): add quoted identifier ignore case option #1800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
reviewed
Apr 30, 2024
There was a problem hiding this comment.
I suppose that means we could've just executed this all along and the behavior would've been fixed...?
I'm not sure we should go down the route of adding session options for every single Snowflake option. I'd rather just document our behavior and suggest manually running this if it is a problem.
Also, is this equivalent to the originally proposed option? I thought the problem was that a user wanted to be able to pass a prequoted, fully qualified name like "DATABASE"."SCHEMA"."TABLE" as the "table name"
|
@davlee1972 is this sufficient to handle your request? Or do we need to explicitly implement an option that turns off the quote wrapping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1766