fix(go/adbc/driver/snowflake): handle empty result sets #1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroshade
reviewed
May 3, 2024
Comment on lines
675
to
681
| } else { | ||
| schema, err := rowTypesToArrowSchema(ctx, ld, useHighPrecision) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| rdr.schema, _ = getTransformer(schema, ld, useHighPrecision) | ||
| } |
There was a problem hiding this comment.
Can we make this a bit more readable by flipping the condition and then just returning early in this case?
if len(batches) == 0 {
schema, err := rowTypesToArrowSchema(ctx, ld, useHighPrecision)
if err != nil {
return nil, err
}
rdr.schema, _ = getTransformer(schema, ld, useHighPrecision)
return rdr, nil
}
// rest of code for channel managementThere was a problem hiding this comment.
we could even skip all of the channel creation etc. for this case too most likely
zeroshade
approved these changes
May 4, 2024
|
Added! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1804.