Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(csharp): an assortment of small fixes not worth individual pull requests #1807

Merged
merged 1 commit into from
May 3, 2024

Conversation

CurtHagenlocher
Copy link
Contributor

Closes #1806

@github-actions github-actions bot added this to the ADBC Libraries 1.0.0 milestone May 3, 2024
@@ -29,28 +29,23 @@ public sealed class AdbcCommand : DbCommand
{
private AdbcStatement adbcStatement;
private int _timeout = 30;
private bool _disposed;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will eventually file a work item to be consistent about formatting of field names across the project. This file was egregious in that it had one of each so there was no way to keep the file consistent... .

@CurtHagenlocher CurtHagenlocher changed the title bug(csharp): an assortment of small fixes not worth individual pull requests fix(csharp): an assortment of small fixes not worth individual pull requests May 3, 2024
@CurtHagenlocher CurtHagenlocher merged commit a830bf2 into apache:main May 3, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

csharp: fix bugs discovered when running tests against Snowflake
2 participants