fix(csharp/src/Apache.Arrow.Adbc/C): imported errors don't return a native error or SQL state #1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e native error code and SQLState from the C error structure. Closes apache#1813
|
It turns out that neither DuckDB nor Snowflake are setting these. Maybe PostgreSQL or sqlite would work; something to look at in the future. |
|
|
Ah, I've only started to implement 1.1 functionality so I'd forgotten about that use of the vendor code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates subclass of AdbcException for imported drivers which reads the native error code and SQLState from the C error structure.
Closes #1813