fix(dev/release): handle versioning scheme in binary verification #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroshade
reviewed
May 8, 2024
|
@kou how does this look? I am working on a new release, but the binary verification failed: https://github.com/apache/arrow-adbc/actions/runs/8994046699/job/24706918875 |
kou
approved these changes
May 8, 2024
| @@ -693,6 +702,8 @@ test_linux_wheels() { | |||
| local arch="x86_64" | |||
| fi | |||
|
|
|||
| local declared_package_version="${VERSION_NATIVE}" | |||
| local package_version="${TEST_PYARROW_VERSION:-${declared_package_version}}" | |||
There was a problem hiding this comment.
Suggested change
| local package_version="${TEST_PYARROW_VERSION:-${declared_package_version}}" | |
| local package_version="${TEST_ADBC_VERSION:-${declared_package_version}}" |
Or TEST_ADBC_PYTHON_VERSION.
(I think that we can always use ${VERSION_NATIVE} here.)
There was a problem hiding this comment.
Changed to always use VERSION_NATIVE
| # apple silicon processor | ||
| if [ "$(uname -m)" = "arm64" ]; then | ||
| local platform_tags="arm64" | ||
| else | ||
| local platform_tags="x86_64" | ||
| fi | ||
|
|
||
| local declared_package_version="${VERSION_NATIVE}" | ||
| local package_version="${TEST_PYARROW_VERSION:-${declared_package_version}}" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1833.