-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rust): add integration tests and some improvements #1883
Conversation
Anything I can do to help make progress here? |
Sorry, I've been quite busy these past two weeks. I just updated the description of the PR which should give you up-to-date informations. I think you can start reviewing it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Presumably that clang-tidy check doesn't need to be in the Rust pipeline? But that can be fixed separately |
See the integration.yml pipeline which does this - can probably duplicate it for Rust or figure out how to work Rust into it |
This should be the last PR for the initial Rust implementation.
It includes:
Note that I also have an integration test for the driver manager against the official PostgreSQL driver but it needs a running PostgreSQL instance to be executed, so it cannot be easily integrated into the CI. This test proved useful during development as it allowed me to catch some bugs. The existence of this test is the reason why there is a common module. Maybe we can add it in a follow-up PR?