fix(csharp/src/Drivers/Apache/Spark): fix parameter naming convention #1895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
davidhcoe
commented
Jun 3, 2024
davidhcoe
commented
- Adds the parameter naming convention to match other adbc projects
- Fixes the UserAgent name
added 2 commits
June 3, 2024 10:52
| @@ -38,7 +38,7 @@ namespace Apache.Arrow.Adbc.Drivers.Apache.Spark | |||
| { | |||
| public class SparkConnection : HiveServer2Connection | |||
| { | |||
| const string UserAgent = "MicrosoftSparkODBCDriver/2.7.6.1014"; | |||
| private readonly string UserAgent = $"{InfoDriverName.Replace(" ", "")}/{ProductVersionDefault}"; | |||
There was a problem hiding this comment.
Note that some servers actually change their behavior based on the reported client version -- Snowflake definitely does this -- so while this change is right in principle it may have consequences in practice.
CurtHagenlocher
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.