feat(c/driver/postgresql): Read/write support for TIME64[us] #1960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
changed the title
WillAyd
changed the title
WillAyd
commented
Jul 1, 2024
| adbc_validation::Handle<struct ArrowArray> array; | ||
| struct ArrowError na_error; | ||
|
|
||
| const enum ArrowTimeUnit unit = NANOARROW_TIME_UNIT_MICRO; |
There was a problem hiding this comment.
hard coded for now, but when we add nano support this will be parametrized (we have the same pattern for timestamp tests)
lidavidm
approved these changes
Jul 2, 2024
c/driver/postgresql/copy/writer.h
Outdated
| *out = std::make_unique<PostgresCopyNetworkEndianFieldWriter<int64_t>>(); | ||
| return NANOARROW_OK; | ||
| default: | ||
| return ADBC_STATUS_INVALID_STATE; |
lidavidm
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One step towards #1950
Just doing microsecond support for now. Can add nanosecond support and time32 as a follow up
Reading was already implemented but untested. Added some shared test data to go with the writer