fix(c/vendor/nanoarrow): Fix -Wreorder warning #1966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
approved these changes
Jul 4, 2024
paleolimbot
added a commit
to paleolimbot/arrow-adbc
that referenced
this pull request
Jul 9, 2024
In some of the R packages we get: ``` * checking whether package 'adbcsqlite' can be installed ... [35s] WARNING Found the following significant warnings: ../src/c/vendor/nanoarrow/nanoarrow.hpp:868:19: warning: 'nanoarrow::ViewArrayStream::code_' will be initialized after [-Wreorder] ../src/c/vendor/nanoarrow/nanoarrow.hpp:867:15: warning: 'ArrowError* nanoarrow::ViewArrayStream::error_' [-Wreorder] ../src/c/vendor/nanoarrow/nanoarrow.hpp:828:3: warning: when initialized here [-Wreorder] See 'D:/a/arrow-adbc/arrow-adbc/r/adbcsqlite/check/adbcsqlite.Rcheck/00install.out' for details. ``` https://github.com/apache/arrow-adbc/actions/runs/9788345921/job/27026279250?pr=1965#step:10:166 This has already been fixed upstream: https://github.com/apache/arrow-nanoarrow/blob/c74bb37b990541c82305b000b516f922db74d1f9/src/nanoarrow/nanoarrow.hpp#L846
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some of the R packages we get:
https://github.com/apache/arrow-adbc/actions/runs/9788345921/job/27026279250?pr=1965#step:10:166
This has already been fixed upstream:
https://github.com/apache/arrow-nanoarrow/blob/c74bb37b990541c82305b000b516f922db74d1f9/src/nanoarrow/nanoarrow.hpp#L846