feat(c/driver/postgresql): FIXED_SIZED_LIST Writer support #1975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
commented
Jul 5, 2024
| @@ -452,13 +454,21 @@ class PostgresCopyListFieldWriter : public PostgresCopyFieldWriter { | |||
| constexpr int32_t ndim = 1; | |||
| constexpr int32_t has_null_flags = 0; | |||
|
|
|||
| const int32_t start = ArrowArrayViewListChildOffset(array_view_, index); | |||
| const int32_t end = ArrowArrayViewListChildOffset(array_view_, index + 1); | |||
| // TODO: the LARGE_LIST should use 64 bit indexes | |||
There was a problem hiding this comment.
Just discovered this as an issue in the current implementation - if there happens to be a LARGE_LIST that has a gap between the start/end offsets exceeding 32 bits of storage then we have to raise, as it would exceed what postgres allows for the dim field
I figured easier done in a follow up, but happy to do in this as well
There was a problem hiding this comment.
I'm OK with a followup since I'm just going to merge this :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another enhancement for #1882