feat(c): Add pkgconfig support to Meson build system #1992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
reviewed
Jul 9, 2024
c/driver/flightsql/meson.build
Outdated
Comment on lines
51
to
52
| name: 'adbc_driver_flightsql', | ||
| description: 'ADBC Driver for FlightSQL', |
There was a problem hiding this comment.
Could you use the same content as existing .pc?
https://github.com/apache/arrow-adbc/blob/main/c/driver/flightsql/adbc-driver-flightsql.pc.in
(If the existing content isn't is strange, could you improve it?)
There was a problem hiding this comment.
Sounds good. I noticed two of the CMake config files were missing the URL so added those as well. Happy to split off if you want to manage that in a separate PR
|
Should we create an issue for this? |
|
Just created #2000 |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2000.