refactor(c/driver/postgresql): Factory func for CopyWriter construction #1998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
reviewed
Jul 10, 2024
| @@ -92,13 +92,20 @@ class PostgresCopyFieldWriter { | |||
| public: | |||
| virtual ~PostgresCopyFieldWriter() {} | |||
|
|
|||
| void Init(struct ArrowArrayView* array_view) { array_view_ = array_view; }; | |||
| template <class T, typename... Params> | |||
| static std::unique_ptr<T> Create(struct ArrowArrayView* array_view, Params&&... args) { | |||
There was a problem hiding this comment.
I don't think this even needs to be a static method? It could just be a free function and you can then just invoke
*out = MakeWriter<T>(array_view);There was a problem hiding this comment.
I think would have to make the Init method public to do that - do you think that is better?
../driver/postgresql/copy/writer.h:564:15: error: ‘virtual void adbcpq::PostgresCopyFieldWriter::Init(ArrowArrayView*)’ is protected within this context
564 | writer->Init(array_view);
| ~~~~~~~~~~~~^~~~~~~~~~~~
../driver/postgresql/copy/writer.h:100:16: note: declared protected here
100 | virtual void Init(struct ArrowArrayView* array_view) { array_view_ = array_view; };There was a problem hiding this comment.
Ah...
This is fine then. The T::Create<T> bugged me a little bit but it's not actually a problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #1962, which required each writer construction to subsequently call
->Init()to assign to a protected array_view_ member.This takes inspiration from the following cpp guideline to have the class manage its construction more appropriately:
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#discussion-use-a-factory-function-if-you-need-virtual-behavior-during-initialization