Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): correct snowflake options for bulk ingest #2004

Merged
merged 3 commits into from
Jul 12, 2024

Conversation

zeroshade
Copy link
Member

It was brought up in #1997 that the currently published options for snowflake bulk ingestion are incorrect in the docs. This corrects them to the proper values that are consistent with the values in the implementation.

This also adds new constants to the python StatementOptions enum for the snowflake driver for users to reference.

@zeroshade zeroshade requested a review from joellubi July 11, 2024 15:25
@zeroshade zeroshade requested a review from lidavidm as a code owner July 11, 2024 15:25
@github-actions github-actions bot added this to the ADBC Libraries 14 milestone Jul 11, 2024
@lidavidm
Copy link
Member

Looks like we just need to fix the lint errors

@zeroshade zeroshade merged commit a5f8474 into apache:main Jul 12, 2024
58 checks passed
@zeroshade zeroshade deleted the update-docs-snowflake-options branch July 12, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants