Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(go/adbc/driver/snowflake): split files properly after reaching targetSize on ingestion #2026

Merged
merged 5 commits into from
Jul 29, 2024
Merged

fix(go/adbc/driver/snowflake): split files properly after reaching targetSize on ingestion #2026

merged 5 commits into from
Jul 29, 2024

Conversation

joellubi
Copy link
Member

@joellubi joellubi commented Jul 18, 2024 •
edited
Loading

Fixes: #1997

Core Changes

  • Change ingestion writeParquet function to use unbuffered writer, skipping 0-row records to avoid recurrence of adbc_ingest() is dropping rows in Snowflake #1847
  • Use parquet writer's internal RowGroupTotalBytesWritten() method to track output file size in favor of limitWriter
  • Unit test to validate that file cutoff occurs precisely when expected

Secondary Changes

  • Bump arrow dependency to v18 to pull in the changes from ARROW-43326
  • Fix flightsql test that depends on hardcoded arrow version

@joellubi joellubi marked this pull request as ready for review July 19, 2024 16:48
@joellubi joellubi requested a review from zeroshade as a code owner July 19, 2024 16:48
@github-actions github-actions bot added this to the ADBC Libraries 14 milestone Jul 19, 2024
@joellubi joellubi mentioned this pull request Jul 19, 2024
Closed
zeroshade
zeroshade reviewed Jul 25, 2024
View reviewed changes
Copy link
Member

@zeroshade zeroshade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do a rebase please? I believe the version was already bumped to v18 for Arrow

go/adbc/driver/snowflake/bulk_ingestion.go Outdated Show resolved Hide resolved
@joellubi
Copy link
Member Author

Can you do a rebase please? I believe the version was already bumped to v18 for Arrow

Sure, just rebased and applied your comment.

@joellubi joellubi requested a review from zeroshade July 29, 2024 20:35
@zeroshade zeroshade merged commit d05e1ba into apache:main Jul 29, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeroshade zeroshade zeroshade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ADBC Libraries 14
2 participants
@joellubi @zeroshade