Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(csharp/src/Drivers/BigQuery): add support for configurable query timeouts #2043

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

davidhcoe
Copy link
Contributor

Adds a new option to support specifying the timeout value for a query

Copy link
Contributor

@CurtHagenlocher CurtHagenlocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I made a few small recommendations for changes, but wouldn't call any of them blockers.

csharp/src/Drivers/BigQuery/BigQueryConnection.cs Outdated Show resolved Hide resolved
csharp/src/Drivers/BigQuery/BigQueryConnection.cs Outdated Show resolved Hide resolved
csharp/src/Drivers/BigQuery/BigQueryStatement.cs Outdated Show resolved Hide resolved
csharp/test/Drivers/BigQuery/BigQueryTestingUtils.cs Outdated Show resolved Hide resolved
@CurtHagenlocher CurtHagenlocher merged commit bf31b1f into apache:main Jul 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants