refactor(c/driver/framework): Separate C/C++ conversions and error handling into minimal "base" framework #2090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
changed the title
lidavidm
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the previous
driver/common/driver_base.hand refactorsdriver/framework/base_driver.hsuch that it can be a (almost) drop-in replacement. This is basically to separate the nanoarrow helpers such that framework drivers don't have to use them (or can adopt them incrementally to improve/simplify their implementation if they would like): driver authors can implement the low-level methods with C inputs, implement slightly higher level C++-y methods withStatuserror handling and inputs already converted to C++ objects, or link to the framework. All of our C++ drivers will continue to (or should eventually) link to/use the framework.I am not sure the separation is perfect here and I'm happy to change things that don't make sense!