-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(c/driver/postgresql): Implement ingestion of list types for PostgreSQL #2153
Merged
paleolimbot
merged 15 commits into
apache:main
from
paleolimbot:c-driver-postgres-list-ingest
Sep 12, 2024
Merged
feat(c/driver/postgresql): Implement ingestion of list types for PostgreSQL #2153
paleolimbot
merged 15 commits into
apache:main
from
paleolimbot:c-driver-postgres-list-ingest
Sep 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidavidm
approved these changes
Sep 12, 2024
c/driver/postgresql/postgres_type.h
Outdated
@@ -183,6 +183,26 @@ class PostgresType { | |||
const std::string& field_name() const { return field_name_; } | |||
int64_t n_children() const { return static_cast<int64_t>(children_.size()); } | |||
const PostgresType& child(int64_t i) const { return children_[i]; } | |||
const std::string create_table_name() const { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be named TypeName or something? Not table name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds list ingest support in the PostgreSQL driver. The raw COPY and type support had already been added; however, there were still some hard-coded switch-on-type that implemented some necessary features (e.g., the CREATE TABLE syntax for each type). I moved these to the type/copy section and removed the previous implementation (which should also help for a future PR implementing the ability to bind nested types as parameters).
I also added the infrastructure to test this in all drivers via the validation suite, which required modifying some of the built-in concepts to accommodate a nested type.
Closes #2066.
Created on 2024-09-11 with reprex v2.1.1