Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(csharp/src/Drivers/Apache/Spark): correct precision/scale handling with zeros in fractional portion #2198

Conversation

birschick-bq
Copy link
Contributor

Fixed two bugs

  1. scale should be able to be the same as precision
  2. when leading zeros in fractional portion and positive exponent, the significant digits where not calculated correctly.

Copy link
Contributor

@CurtHagenlocher CurtHagenlocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@CurtHagenlocher CurtHagenlocher merged commit c391168 into apache:main Sep 27, 2024
8 checks passed
@birschick-bq birschick-bq deleted the dev/birschick-bq/fix-decimal-conv-bug branch October 15, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants