-
Notifications
You must be signed in to change notification settings - Fork 162
docs(r/adbcbigquery,r/adbcflightsql,r/adbcsnowflake): recommend to install from R-multiverse #2262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…install from R-multiverse
paleolimbot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
|
Dear @eitsupi @paleolimbot,
As it appears that the adbc go using drivers are using the c-shared buildmode, i wondered if this is the reason the packages where not submitted to CRAN and if anybody ever encountered this issue golang/go#65050. In my use-case since i can avoid using cgo by reworking the package, therefore i may be requesting the a simple go installation on the windows machine. For the other "Rgo" suggestion, i wondered if there are any plans/appetite for this. And feeback from go enthusiasts is highly welcomed. Best wishes |
|
Thanks for the info! I think there was a similar discussion about Rust before, but I think something like rgo is really unnecessary and what's needed is a proper installation of Go on the CRAN machines. (As an aside, Rust is now installed, but there are frequent issues with version updates.) Personally, I don't want to put in a lot of effort to submit to CRAN because R-multiverse works well. |
|
Cool! I sent a note on the R package dev mailing list about the Go issue with details of the adbcsnowflake submission that I abandoned some time ago. We've never had requests for CRAN distribution and so I assume the R-multiverse is working (or nobody uses the R package!).
Yes, we encounter it on MacOS intel when using multiple go-based ADBC drivers at once but haven't since. The same issue in theory occurs for the Python versions of these drivers (which are used more widely) and we haven't seen user reports of crashes or excessive memory usage of which I'm aware. |
I've only seen it in use once 🙂 |
Thank you for the intervention and the explanation of the journey ! At least all of this can be found more easily now. The go 1.21 regression on the issue is a shame (but i guess somebody really need the "performance hack" for go users of). Also great to see that the go runtimes are isolated in the adbc packages ! |
|
FWIW, it might be possible to fix the Go issue on macOS/Intel, it's just that given that platform is on its way out, it's probably not worth spending the time trying to get something upstream. If it started happening on other platforms a fix would be a high priority though. |
Granted that r-multiverse is more convenient bu we should at least get the go compiler on CRAN for the modest use-case of building go binaries for packages that just use executable (or even bootstrap a different go version if needed). |
As you may know, it looks like it (may) happen sporadically on other platforms too. But as you probably saw on the issue golang/go#65050, the go core members are very dismissive of the whole thing and the "performance hack" that led to the "regression" because the "intended use" was supposed to be different. They suggest using plugins, but that package is not portable. |
|
Given these restrictions and the use cases i am targeting, i thought it would be more productive using arrow IPC and other IPC setups, so i made package that uses nanoarrow and nanonext on the R side and mangos and arrow-go on the go side https://github.com/sounkou-bioinfo/mangoro |
Close #1647
In the short term, CRAN is unlikely to accept Go-based packages, so for now we can recommend installation from R-multiverse.
We can also use the ASF repo of R-universe (https://apache.r-universe.dev/), but R-multiverse is more reliable because it is tied to the latest release with certainty.
Note that
adbcbigqueryhas not been added to R-multiverse yet (r-multiverse/contributions#213 will be merged after ADBC 15 release)